This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Adds example to goto documentation #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe an example with |
Updates example to show how to use async promise functionality.
|
I changed the example a bit and added a sentence to the promise documentation. I'm not sure how elaborate of an example is warranted. Should I do one that does something both on resolve as well as reject or is this fine? |
|
I went to push a couple of tweaks before squashing merging this, but apparently you didn't enable allowing maintainers to push to the branch this PR is from. |
|
My bad @Conduitry, enabled it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a bit confused as to where I would import goto from so I added a small usage example.